Feature : Blocked entries methods #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: read only queries does not need select for update
badgerwithagun
requested changes
Dec 17, 2022
transactionoutbox-core/src/main/java/com/gruelbox/transactionoutbox/TransactionOutboxImpl.java
Show resolved
Hide resolved
...box-core/src/test/java/com/gruelbox/transactionoutbox/acceptance/AbstractAcceptanceTest.java
Outdated
Show resolved
Hide resolved
| + ALL_FIELDS | ||
| + " FROM " | ||
| + tableName | ||
| + " WHERE blocked = true AND processed = false ORDER BY lastAttemptTime DESC LIMIT ? OFFSET ?")) { |
There was a problem hiding this comment.
This needs to be updated to handle different dialects (LIMIT isn't supported by Oracle).
Sorry @RomainWilbert; I got around to re-checking this PR after the Oracle PR was merged.
| * .uniqueRequestId("my-request") | ||
| * .schedule(MyService.class) | ||
| * .runMyMethod("with", "some", "arguments");</pre> | ||
| * <pre> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added 2 methods in TransactionOutbox :
This could be usefull to create a retry screen for blocked entries