Scope fixes for the Spring extension #53
Conversation
…e with spring transactions.
… into gruelbox-master
transactionoutbox-spring/pom.xml
Outdated
| @@ -59,18 +62,22 @@ | |||
| <dependency> | |||
| <groupId>ch.qos.logback</groupId> | |||
| <artifactId>logback-classic</artifactId> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
Were these dependencies deliberately not "test"?
There was a problem hiding this comment.
They're set to test in the parent dependencyManagement.
https://github.com/gruelbox/transaction-outbox/blob/master/pom.xml#L129
There was a problem hiding this comment.
By making the Spring dependencies provided, we're setting up for a situation where a breaking change in Spring causes odd runtime failures with transaction-outbox later. I wonder if this is one of those rare cases where it's worth sticking with the default scope and investigating a version range option for the published POM? That way we can safely and gracefully up or downgrade only to tested versions.
Pretty sure the test scope additions are unnecessary.
|
@tsg21, It'd be really useful if you could spare a moment to give |
|
bump @tsg21 |
* Remove dependency on Hibernate and use Spring's utilities to integrate with spring transactions. * Move the check for an active transaction. Remove an unnecessary try-catch. * Switch spring dependencies to "provided" scope and test dependencies to "test" scope. * Remove duplicate jdbc dependency. * Remove duplicated test scope directives Co-authored-by: Graham Crockford <6483013+badgerwithagun@users.noreply.github.com> (cherry picked from commit f16f1b2)
Fixes #44