Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Key/Value displayed/consumed is inverted #2

Closed
westshawn opened this issue Aug 24, 2015 · 4 comments
Closed

Documentation for Key/Value displayed/consumed is inverted #2

westshawn opened this issue Aug 24, 2015 · 4 comments

Comments

@westshawn
Copy link

Thanks for your work on this great plugin!

I noticed one small issue on https://github.com/grundic/teamcity-web-parameters under the "Web-service" section:

Each element in options's array is hash; key will be option's display name, value will be option's value, enabled will determine if option will be enabled.

In practice, it seems like the key/value are inverted: the "value" from the hash is displayed in the select list, and the "key" from the hash is being consumed by TeamCity.

@grundic
Copy link
Owner

grundic commented Aug 24, 2015

@westshawn, thank you for you time for creating this issue! I've checked it right now -- everything works just like you said, my bad.
In order to keep compatibility with already running and configured services, I'd better just swap items in documentation.

@grundic
Copy link
Owner

grundic commented Aug 24, 2015

Well, and here is the bug itself

grundic added a commit that referenced this issue Aug 25, 2015
@grundic
Copy link
Owner

grundic commented Aug 25, 2015

@westshawn, the issue is fixed now, you can download version 1.2.0 and check it.
Thank you!

@grundic grundic closed this as completed Aug 25, 2015
@westshawn
Copy link
Author

@grundic,
Thanks for the lightning-fast fix.
It works as expected.
Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants