-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the ipaddress
module to detect valid IPV6
#164
Comments
With python 3.11.4 it fails already without changing anything in furl? I'm getting
|
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this issue
Jul 6, 2023
https://build.opensuse.org/request/show/1096865 by user mcepl + favogt_factory FOR STAGING:A - Add 165-use-ipaddress-library.patch to use standard ipaddress library to parse IP addresses (gh#gruns/furl#164).
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this issue
Jul 9, 2024
Fix gruns/furl#164 by using standard ipaddress library to detect valid and invalid IPs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was surprised to see that furl would allow invalid but well-formed IPV6:
furl/tests/test_furl.py
Lines 1658 to 1661 in 7748462
I would suggest to use the IPV6Address object from the python3 ipaddress module to validate IPV6. For python2 I would suggest using the ipaddress backport on pypi.
If it is OK I would volunteer for a PR. What do you think?
The text was updated successfully, but these errors were encountered: