Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path issues with source maps #117

Merged
merged 1 commit into from
Feb 20, 2015

Commits on Feb 18, 2015

  1. Fix path issues with source maps

    On windows, node's path api returns backslashes for path separators.
    Because the source-map library expects forward slashes in all cases,
    their relative path logic (specifically their "normalize" function)
    gives incorrect results when passing in backslash.  The
    mozilla/source-map library won't change this, because they are actually
    expecting URLs as input - see
    mozilla/source-map#91 (comment).
    
    This fix is similar to the one made for grunt-contrib-uglify:
    gruntjs/grunt-contrib-uglify#175.
    
    Standardized line endings for test fixtures by enforcing LF end of files for fixtures directory
    (through repository .gitattributes).  This change was needed
    because the expected output of source maps are based on input files with LF, rather
    than CRLF. Before this change the tests were breaking due to git autocrlf on Windows.
    The difference between the source maps generated from input
    files using CRLF and the source maps generated from input files using
    only LF can't be normalized in the test, due to the nature of the
    changes:  the offsets in the source map are changed, as well as the
    embedded source.  These kinds of changes aren't as simple to normalize
    as just line feeds in output files - and such normalization would be too
    invasive, to the point of making the test less effective.
    
    This should fix issue gruntjs#110 and gruntjs#95 and all unit tests should now pass.
    riaann committed Feb 18, 2015
    Configuration menu
    Copy the full SHA
    ac88c56 View commit details
    Browse the repository at this point in the history