Fix deprecation warning in Node.js 7 #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in Node.js v7.0.0, omitting the callback to async functions emits a deprecation warning. Update the call to `fs.unlink` to instead use `fs.unlinkSync`, which does not expect a callback.
|
|
|
Bump. |
|
I made a PR for this exact same thing a few days ago, not realizing this PR already addressed this. The deprecation warning in Node 7+ is now a real-deal error in Node 10. Is there anything we can do to move forward on getting this updated? It's such a small change... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in Node.js v7.0.0, omitting the callback to async functions
emits a deprecation warning. Update the call to
fs.unlinkto insteaduse
fs.unlinkSync, which does not expect a callback.