Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source maps in Windows #181

Closed
UltCombo opened this issue Mar 19, 2014 · 2 comments · Fixed by #183
Closed

Source maps in Windows #181

UltCombo opened this issue Mar 19, 2014 · 2 comments · Fixed by #183

Comments

@UltCombo
Copy link
Contributor

@jmeas did you change the committed files after opening this PR?

I've added a comment here.

Guess it would be better to do file = (pathPrefix + basename).replace(/\\/g, '/'); at L48
@jamesplease
Copy link
Member

Ah, yeah, I didn't think uglify used what was passed into parse for the source maps. I should have checked with you, first. I'll change this tonight.

@UltCombo
Copy link
Contributor Author

No problem. =]

jamesplease added a commit that referenced this issue Mar 20, 2014
@jamesplease
Amended replacement of path slashes
30b559c 
Slashes in the paths are now replaced before being sent to the parser.
This is for generating source maps on Windows with forward slashes in
the paths. Fixes #181
@jamesplease jamesplease mentioned this issue Mar 20, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Amended replacement of path slashes gruntjs/grunt-contrib-uglify
2 participants
@UltCombo @jamesplease