Handle multiple onLoadFinished callbacks with no-op #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaredstehler-cengage one thing you will have to do is update the package.json to 0.0.4 since the 0.0.3 is already realeased |
pulling latest master
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My jasmine test suite make heavy use of iframes, and I've seen that the onLoadFinished callback gets invoked multiple times during the course of the suite run, once for the main page and again for iframes. Sometimes one of these frames fails (possibly due to a dummy or null src?) and it causes the phantom proc to exit in this function. With this code in place my suite runs to completion successfully.
I found a similar fix committed in guard-jasmine a while back: guard/guard-jasmine#19