Waiting for output streams to have finished before exiting grunt. #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes #510. |
|
+1 |
|
At this point, I'm not going to merge changes this substantial into 0.3 stable. Please upgrade to grunt 0.4.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
gruntand piping its output to some other application (this happens for example when calling it from Cygwin bash under Windows, or as part of a larger build process), the end of the output from Grunt is often lost, because Grunt is exiting before all the data has been sent.This pull request adds some code to make sure all the output has been received by
stdinandstdoutbefore exiting.You can check this for more information:
https://groups.google.com/forum/?fromgroups=#!topic/nodejs-dev/Tj_HNQbvtZs