Add support for pagination #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yevgeniy Brikman <brikis98@users.noreply.github.com>
Used Regex to parse Link headers instead of splits and index arthemtic. getNextPath now returns `string` and `*FetchError`.
|
Thank you so much for making the changes. Sorry, I've been super busy for the past few days, so I wasn't able to work on the changes you suggested. 👍🏽 🙏🏽 |
|
Thanks for the review! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #83 re-opened with some minor clean up. This should fix #26 and #46. Thank you to @m-bal for doing most of the work!