Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update landing zone deployment guide with instructions on how to import existing resources #366

Merged
merged 5 commits into from
Oct 14, 2020

Conversation

brikis98
Copy link
Member

@brikis98 brikis98 commented Oct 13, 2020

Due to a Terraform bug, the import command is broken on our account-baseline-xxx modules, so this PR updates the deployment guide with the workaround that allows users to import existing AWS organizations, child accounts, and IAM users.

Bonus fix: move the -parallelism settings into terragrunt.hcl so they are applied automatically to all relevant commands and you don't have to remember to add it manually.

Direct link for easier reading.

@netlify
Copy link

netlify bot commented Oct 13, 2020

Deploy preview for keen-clarke-470db9 ready!

Built with commit 934fcad

https://deploy-preview-366--keen-clarke-470db9.netlify.app

@netlify
Copy link

netlify bot commented Oct 13, 2020

Deploy preview for keen-clarke-470db9 ready!

Built with commit 407916f

https://deploy-preview-366--keen-clarke-470db9.netlify.app

@brikis98
Copy link
Member Author

CC @robmorgan

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brikis98
Copy link
Member Author

Thanks for the review! @eak12913 What's the process these days for deployment? Merge & release? Or should only platform team do releases?

@infraredgirl
Copy link
Contributor

Thanks for the review! @eak12913 What's the process these days for deployment? Merge & release? Or should only platform team do releases?

FWIW, I did my own release when I added myself to the About page.

@brikis98
Copy link
Member Author

Good point @infraredgirl!

@brikis98 brikis98 merged commit 1edda49 into master Oct 14, 2020
@brikis98 brikis98 deleted the lz-import branch October 14, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants