Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log terraform version in debug mode #1219

Merged

Conversation

alexkayabula
Copy link
Contributor

@alexkayabula alexkayabula commented Jun 16, 2020

What does this PR do?

  • This PR provides enhancement for issue 1213.

Description of task to be completed?

  • The PR enables logging of Terraform version during debug mode.

cli/version_check.go Outdated Show resolved Hide resolved
@alexkayabula alexkayabula force-pushed the log-terraform-version-in-debug-mode branch 2 times, most recently from a037cc3 to 3667cf0 Compare June 18, 2020 13:03
@alexkayabula alexkayabula requested a review from brikis98 June 18, 2020 13:07
cli/version_check.go Outdated Show resolved Hide resolved
@alexkayabula alexkayabula force-pushed the log-terraform-version-in-debug-mode branch 2 times, most recently from b3135e2 to 942fe47 Compare June 19, 2020 08:12
@alexkayabula alexkayabula requested a review from brikis98 June 19, 2020 08:14
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll kick off tests shortly.

cli/version_check.go Outdated Show resolved Hide resolved
@alexkayabula alexkayabula force-pushed the log-terraform-version-in-debug-mode branch from 942fe47 to 667dd2d Compare June 22, 2020 08:42
@alexkayabula alexkayabula requested a review from brikis98 June 22, 2020 08:44
@brikis98
Copy link
Member

Thanks! Re-running tests...

@brikis98
Copy link
Member

Tests passed! Merging now.

@brikis98 brikis98 merged commit 0b24787 into gruntwork-io:master Jun 23, 2020
@brikis98
Copy link
Member

@alexkayabula
Copy link
Contributor Author

Hooray!!!..... My first terragrunt PR has been merged. Thank you @brikis98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants