Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP dependencies update #2775

Merged
merged 26 commits into from
Nov 5, 2023
Merged

GCP dependencies update #2775

merged 26 commits into from
Nov 5, 2023

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Nov 1, 2023 •
edited
Loading

Description

Included changes:

  • Updated GCP dependencies to support "type": "external_account_authorized_user"

Fixes #2773.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Updated GCP dependencies to handle "type": "external_account_authorized_user"

Migration Guide

@denis256 denis256 marked this pull request as ready for review November 3, 2023 21:31
@levkohimins levkohimins self-requested a review November 5, 2023 14:44
levkohimins
levkohimins approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@denis256 denis256 merged commit 0f694f3 into master Nov 5, 2023
3 checks passed
@denis256 denis256 deleted the bug/gcp-creds-2773 branch November 5, 2023 17:58
@BrewTestBot BrewTestBot mentioned this pull request Nov 5, 2023
Merged
@FabioAntunes FabioAntunes mentioned this pull request Nov 13, 2023
Closed
@renovate renovate bot mentioned this pull request Jul 17, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levkohimins levkohimins levkohimins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terragrunt doesn't support gcp's credentials with"type": "external_account_authorized_user"
2 participants
@denis256 @levkohimins