Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update S3 bucket creation to pass ObjectOwnership #1272

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Update S3 bucket creation to pass ObjectOwnership #1272

merged 3 commits into from
Apr 25, 2023

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Apr 23, 2023 •
edited
Loading

Description

Included changes:

  • fixed terraform-aws-s3-example
  • updated S3 bucket creation to set ObjectOwnership
  • updated test TestAssertS3BucketPolicyExists to not set Deny ACL instead of Allow(and fail because of this)

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated S3 bucket creation to set object ownership.

Migration Guide

@zackproser
Copy link
Contributor

Took a swing through the failed tests and many are flaky - code changes LGTM so going to approve.

zackproser
zackproser reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zackproser
zackproser previously approved these changes Apr 24, 2023
View reviewed changes
zackproser
zackproser approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denis256 denis256 merged commit 6c49de6 into master Apr 25, 2023
@denis256 denis256 deleted the s3-tests-fix branch April 25, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackproser zackproser zackproser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis256 @zackproser