Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fixes #1275

Merged
merged 12 commits into from
Apr 27, 2023
Merged

Test fixes #1275

merged 12 commits into from
Apr 27, 2023

Conversation

ellisonc
Copy link

Description

Fixes many tests

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Test fixes

MoonMoon1919
MoonMoon1919 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@MoonMoon1919 MoonMoon1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellisonc ellisonc merged commit 0d72561 into master Apr 27, 2023
@ellisonc ellisonc deleted the test-fixes branch April 27, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoonMoon1919 MoonMoon1919 MoonMoon1919 approved these changes

@zackproser zackproser Awaiting requested review from zackproser

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellisonc @MoonMoon1919