Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terratest build fixes #1395

Merged
merged 21 commits into from
Jul 12, 2024
Merged

Terratest build fixes #1395

merged 21 commits into from
Jul 12, 2024

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Mar 1, 2024

Description

Included changes:

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Added support for Packer 1.10

Fixed Helm and Packer tests

Migration Guide

@denis256 denis256 changed the title Dependencies update and build fixes Terratest build fixes May 23, 2024
@denis256 denis256 marked this pull request as ready for review May 23, 2024 20:00
modules/aws/rds_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to commit this file? It should be ignored. Please force push the removal of the file so that it's cleaned out of history if not intentional.

Copy link
Member Author

@denis256 denis256 May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is by intention, to deploy on new lambda runtime, executable should be named bootstrap

In the project directory that contains your application's main.go file, compile your executable. Note the following:
The executable must be named bootstrap. For more information, see Naming.

https://docs.aws.amazon.com/lambda/latest/dg/golang-package.html

Copy link

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@denis256 denis256 merged commit 4dfb76d into master Jul 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants