Fix genind2genalex() error with SNP data #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will now allow for numeric or character matrix output. This also changes the argument `mat` to `mat_type` and changes the value from a boolean to a character vector indicating the type of matrix output (if none, no matrix output). This commit will fix #231
|
I'm going to merge this because it fixes the issue it intends to fix, but there is a problem with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
genind2genalex()by fixing the internal functions that converts one locus per column data to one allele per column data to allow for character type data (previously, it was only allowed for numeric type data to provide for the Bruvo functions).This will fix #231