update denominator for bitwise.ia to be int64_t #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows machines apparently do not treat long int the same way that UNIX machines do and caused integer overflows for people who were performing bitwise.ia() on sample sizes of more than 2000 loci x 200 individuals. This wasn't caught earlier because I had skipped these tests on CRAN and appveyor didn't run them either. This fixes the problem and adds a news item. This addresses #234
|
N.B. the tests that are currently failing on windows are failing solely because of trying to match temporary paths on windows and not anything substantial |
We establish that genalex IO works on windows, the rest comes down to manipulation of the imported data once it's in R. The problem is that the Windows runner on GitHub Actions is throwing a fit about tempfiles and I don't care enough to fix them.
|
Mac is failing because of weird LaTeX corner case, but otherwise, it's good to go |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows machines apparently do not treat long int the same way that UNIX
machines do and caused integer overflows for people who were performing
bitwise.ia()on sample sizes of more than 2000 loci x 200 individuals.This wasn't caught earlier because I had skipped these tests on CRAN and
appveyor didn't run them either. This fixes the problem and adds a news
item.
This will fix #234