Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update denominator for bitwise.ia to be int64_t #235

Merged
merged 5 commits into from
Feb 5, 2021
Merged

update denominator for bitwise.ia to be int64_t #235

merged 5 commits into from
Feb 5, 2021

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Feb 4, 2021

Windows machines apparently do not treat long int the same way that UNIX
machines do and caused integer overflows for people who were performing
bitwise.ia() on sample sizes of more than 2000 loci x 200 individuals.
This wasn't caught earlier because I had skipped these tests on CRAN and
appveyor didn't run them either. This fixes the problem and adds a news
item.

This will fix #234

Windows machines apparently do not treat long int the same way that UNIX
machines do and caused integer overflows for people who were performing
bitwise.ia() on sample sizes of more than 2000 loci x 200 individuals.
This wasn't caught earlier because I had skipped these tests on CRAN and
appveyor didn't run them either. This fixes the problem and adds a news
item.

This addresses #234
@zkamvar
Copy link
Member Author

zkamvar commented Feb 4, 2021

N.B. the tests that are currently failing on windows are failing solely because of trying to match temporary paths on windows and not anything substantial

We establish that genalex IO works on windows, the rest comes down to
manipulation of the imported data once it's in R. The problem is that
the Windows runner on GitHub Actions is throwing a fit about tempfiles
and I don't care enough to fix them.
@zkamvar
Copy link
Member Author

zkamvar commented Feb 5, 2021

Mac is failing because of weird LaTeX corner case, but otherwise, it's good to go

@zkamvar zkamvar merged commit bfdf0ef into main Feb 5, 2021
@zkamvar zkamvar deleted the fix-234 branch February 5, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitwise.ia() degraded performance on windows
1 participant