Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more colors for operator in OCaml #144

Closed
wants to merge 3 commits into from

Conversation

scottdlai
Copy link

Hi :D,

I've added colors for operators in OCaml to add more variants for the language.

before

after

Thank you for your time 😃

@undu
Copy link

undu commented Sep 20, 2020

When using neovim's tree-sitter punctuation is highlighted as orange, maybe the theme could be made to be more consistent instead of using aqua.

Example: Screenshot_20200920_201635

I'd like to go over gruvbox's support of tree-sitter highlight groups as well, same as the LSP PR I have open.

@rbong
Copy link

rbong commented Oct 3, 2020

Yeah I'm not sure how I feel about everything using aqua either.

Comment on lines +1597 to +1601
hi! link ocamlOperator GruvBoxAqua
hi! link ocamlKeyChar GruvBoxAqua
hi! link ocamlArrow GruvboxAqua
hi! link ocamlInfixOpKeyword GruvboxAqua
hi! link ocamlConstructor GruvboxYellow
Copy link

@undu undu Oct 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this would take the colours from the already-defined categories, making the code look more consistent with other languages. (The groups were taken from the equivalents in nvim-tree-sitter)

Suggested change
hi! link ocamlOperator GruvBoxAqua
hi! link ocamlKeyChar GruvBoxAqua
hi! link ocamlArrow GruvboxAqua
hi! link ocamlInfixOpKeyword GruvboxAqua
hi! link ocamlConstructor GruvboxYellow
hi! link ocamlOperator Operator
hi! link ocamlKeyChar Delimiter
hi! link ocamlArrow Delimiter
hi! link ocamlInfixOpKeyword Keyword
hi! link ocamlConstructor Special

Copy link

@undu undu Oct 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the code looks like with this change:
Screenshot_20201003_164951

Compare with tree-sitter highlighting:
Screenshot_20201003_165018

rbong added a commit that referenced this pull request Oct 4, 2020
@rbong
Copy link

rbong commented Oct 4, 2020

It looks good. I've merged the changes together in 9e71159

Let me know if there are any problems here or in a new issue

@rbong rbong closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants