Fix: action order with synchronous effects #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| store.state$.subscribe(); | ||
| store.action$.next(aAction); | ||
|
|
||
| await awaitNMockCalls(reducerMock, 4); |
There was a problem hiding this comment.
This is what I wanted to avoid, asyncScheduler makes everything async which might be not desirable if you are operating on sync effects. I was also experimenting with queueScheduler but I couldn't get it working properly.
There was a problem hiding this comment.
For the majority of cases, It probably won't matter though...
There was a problem hiding this comment.
Yup, had the same reflection... But it is definitely the simplest fix 🤷
grzegorz-bielski
approved these changes
Sep 20, 2020
|
Thx @GrzegorzKazana! merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
Actions created in effects are
nexted into the action stream on async tick. This allows actions which triggered the epic to be handled before the newly created one.