Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel button #40

Open
enguerranws opened this issue Oct 19, 2017 · 8 comments
Open

Cancel button #40

enguerranws opened this issue Oct 19, 2017 · 8 comments

Comments

@enguerranws
Copy link

enguerranws commented Oct 19, 2017

Hi,

I'm just wondering how to make a cancel button (or cancel on a tap on the backdrop) using this component. Any ideas?

@gs-akhan
Copy link
Owner

Hi,
Tap on background should close the dropdown.

@enguerranws
Copy link
Author

enguerranws commented Oct 20, 2017

Hi @gs-akhan,

sure it does, but adding a close button (a simple cross in the corner) should make this less implicit? That being said, I guess I can do it by simply adding some styles.

@enguerranws
Copy link
Author

enguerranws commented Oct 20, 2017

That being said, I guess I can do it by simply adding some styles.

Well, no. I would simply add an <Image/> component on the backdrop, but it can't be done right now. Another option would be to have a onOpen onClose property so I could display / hide an
external component based on a state property.

@gs-akhan
Copy link
Owner

gs-akhan commented Oct 20, 2017 via email

@enguerranws
Copy link
Author

Btw how do you plan to add that cross, as an image ? SVG ?

Right now, I think of a RN Image component (as SVG support means some react-native svg module dependency). I actually don't know how to achieve that right now using your plugin: is it possible?

@gs-akhan
Copy link
Owner

gs-akhan commented Oct 20, 2017 via email

@enguerranws
Copy link
Author

There is an indicator component that is used to render a drop icon

The indicator property shows an indicator on the select item itself, not in the modal. I would like to find something to add a close / cancel button inside the modal backdrop.

@gs-akhan
Copy link
Owner

Yes, I was suggesting you can checkout how that drop icon was built. Or you can use ImageComponent too. I am fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants