Fix carousel slot rendering skipped inner scopedSlots #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering the carousel slot with a component, itself using a scopedSlot, it won't be rendered correctly. The scopedSlot is skipped and our component is rendered as if it didn't received any slot.
Example:
Here, the scoped slot
footer
is never rendered, as if we never passed it.I digged into the library to understand the problem and turns out it's a simple typo in the keys to copy when cloning the children
vnode
...Note: I know this won't be merged as the library isn't maintained anymore. I published this fix on my own fork and I'm using this in production for probably ever.