Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.12.3: no more custom js in .md or csv files, just .txt or other misc text files #2365

Closed
4 tasks done
gesu92 opened this issue Jul 25, 2024 · 9 comments · Fixed by #2383
Closed
4 tasks done

v2.12.3: no more custom js in .md or csv files, just .txt or other misc text files #2365

gesu92 opened this issue Jul 25, 2024 · 9 comments · Fixed by #2383
Labels
Milestone

Comments

@gesu92
Copy link

gesu92 commented Jul 25, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

Hello mister, I just update Markor today and noticed that the js custom script it's not execute in .md or .csv files like previus versions, just execute in .txt files u other random text files.

Steps to reproduce

  1. Load javascript in the settings
  2. Open .md or .csv file, nothing happend.
  3. Open other random text file, here is it the javascript.

Information

Android version: 14
Device: Moto X4
App Version: 2.12.3

Source

F-Droid

Format / File type

Not specific

Additional info / Log

No response

@gsantner gsantner changed the title After last update, there is no more custom js in .md or csv files, just .txt or other misc text files v2.12.3: no more custom js in .md or csv files, just .txt or other misc text files Jul 25, 2024
@gsantner
Copy link
Owner

This is about Inject-head settings options right?

@gesu92
Copy link
Author

gesu92 commented Jul 25, 2024

Indeed, in the 2.13.3 there is no more javascript executed in .md and .csv files, I had to downgrade one version of the app meanwhile its solved

@harshad1
Copy link
Collaborator

Could you give me an example with some instructions so I can test it?

@gesu92
Copy link
Author

gesu92 commented Jul 27, 2024

Yeah, I mean, just use some javascript code that can be visually checked, like mmm document.getElementsByTagName("table").item(0).setAttribute("style","background-color: red;");

that should work in .csv and in a .md with a table

@gesu92
Copy link
Author

gesu92 commented Jul 27, 2024

I have a bigger script that I ised with Markor.
First I was thinking that some part are wrong, but casually open a .txt file and work, but in the custom files like .md and .csv does't

@gsantner
Copy link
Owner

gsantner commented Jul 27, 2024

Not sure about your problem, but your question seems to be rather about web development then Markor.

It works here at least:

screenrecord-2024-07-27_14.22.44.webm

@gesu92
Copy link
Author

gesu92 commented Jul 27, 2024

It's not working mr.

5049ff93-2e6b-41b2-a6c2-4e5ea2247f1d.mp4

@gesu92
Copy link
Author

gesu92 commented Jul 27, 2024

The video show How the script works on random .txt files, but in .csv or .md it's not working, in the versión 2.12.3

In the 2.12.2 working fine, if you need I can do the same video but with the 2.12.2 version

@harshad1
Copy link
Collaborator

I see this. Will investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants