Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org Mode check list button inserts lowercase X #2405

Closed
4 tasks done
JonHurst opened this issue Sep 3, 2024 · 0 comments · Fixed by #2504
Closed
4 tasks done

Org Mode check list button inserts lowercase X #2405

JonHurst opened this issue Sep 3, 2024 · 0 comments · Fixed by #2504

Comments

@JonHurst
Copy link

JonHurst commented Sep 3, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

Tapping the Org Mode "Check list" button with an empty check box inserts lower-case x, when it should insert uppercase X

i.e. [ ] Item => [x] Item, rather than [X] Item

Both emacs and the markor view mode for org mode seem to expect uppercase for correct behaviour.

Steps to reproduce

  1. Create an Org Mode file and add "Item" as first line
  2. Click check list button => - [ ] Item
  3. Click check list button again => - [x] Item
  4. Click view button
  5. Click pencil button and change to - [X] Item
  6. Click view button

Information

Android version:
Device:
App Version:

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-
gsantner pushed a commit that referenced this issue Jan 18, 2025
* add replacepattergenerator file for orgmode

we need this to set more correct patterns for orgmode lists and headings, which are
different to markdown ones

fix action button behaviour on unordered and ordered lists

fix checkbox to only use uppercase X as per orgmode specs

add heading action buttons

* prevent bolding of level 3+ headings

more generically, prevent emphasizing a pattern if it's made entirely of
the delimiter character

also fix heading and comments being highlighted across newlines
we were using \s but what we really want is whitespace only
and \s also matches newline

orgmode headings can also be any depth, unlike markdown 1-6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants