Supports UTF-8 file with BOM. #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As of icon, that is OK - thats just what everybody else did so far here :D |
gsantner
reviewed
May 4, 2022
gsantner
reviewed
May 4, 2022
gsantner
reviewed
May 4, 2022
gsantner
force-pushed
the
master
branch
4 times, most recently
from
8bbdc13 to
b9c45c3
Compare
|
I committed all changes. See if I missed something. |
|
OK should I try it on the weekend? |
gsantner
reviewed
May 18, 2022
|
Yeah, tell me if anything I can do. |
gsantner
approved these changes
May 21, 2022
Comment on lines
+180
to
186
| if (appSettings.getNewFileDialogLastUsedUtf8Bom()) { | ||
| arg_fos.write(0xEF); | ||
| arg_fos.write(0xBB); | ||
| arg_fos.write(0xBF); | ||
| } | ||
| if (templateContents != null && (!f.exists() || f.length() < ShareUtil.MIN_OVERWRITE_LENGTH)) { | ||
| arg_fos.write(templateContents); |
There was a problem hiding this comment.
We should get rid of own file writing implementation here and instead use FileUtils, what is used at editor as well.
But that is a topic of it's own.
harshad1
reviewed
May 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code may be a bit rough: