Appearance improvements #2359
Appearance improvements #2359
Conversation
| if (window != null) { | ||
| window.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE | WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_VISIBLE); | ||
| window.setLayout(WindowManager.LayoutParams.WRAP_CONTENT, WindowManager.LayoutParams.WRAP_CONTENT); | ||
| } |
There was a problem hiding this comment.
This has to be done after show().
(IMO bad design by the Android devs)
| _recyclerList.addItemDecoration(dividerItemDecoration); | ||
| // final LinearLayoutManager lam = (LinearLayoutManager) _recyclerList.getLayoutManager(); | ||
| // final DividerItemDecoration dividerItemDecoration = new DividerItemDecoration(activity, lam.getOrientation()); | ||
| // _recyclerList.addItemDecoration(dividerItemDecoration); |
There was a problem hiding this comment.
Divider decoration not needed. The items do this themselves?
There was a problem hiding this comment.
Depends on how it's used. Generally the builtin Recyclerview decoration are better performant but in case there is a own one, of course bad to have multiple.
app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserDialog.java
Show resolved
Hide resolved
|
|
||
| holder.image.postDelayed(() -> { |
There was a problem hiding this comment.
@gsantner You added this postDelayed in 2022. Do you remember why?
The code works well without it...
There was a problem hiding this comment.
Very likely because it was crashing on some devices without it.
| final Window window = dialog.getWindow(); | ||
| if (window != null) { | ||
| window.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE | WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_VISIBLE); | ||
| window.setLayout(WindowManager.LayoutParams.WRAP_CONTENT, WindowManager.LayoutParams.WRAP_CONTENT); |
There was a problem hiding this comment.
Should be match_parent I guess for better usage? See latest issue
(cherry picked from commit c4ba9e7)
This PR adds some appearance improvements: