Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bugfixes (anchor/toc jumping, snippets folder, wikitext newfile, virtual directory browser) #2370

Merged
merged 4 commits into from
Jul 27, 2024

Conversation

harshad1
Copy link
Collaborator

@harshad1 harshad1 commented Jul 27, 2024

@gsantner gsantner added the bug label Jul 27, 2024
@gsantner gsantner added this to the Markor v2.13 milestone Jul 27, 2024
@gsantner gsantner changed the title Fix jump to heading Various bugfixes (anchor/toc jumping, snippets folder, wikitext newfile, virtual directory browser) Jul 27, 2024
Copy link
Owner

@gsantner gsantner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your fixes and quick changes. I want to release them soon.

@gsantner gsantner merged commit 57aaf0f into gsantner:master Jul 27, 2024
1 check passed
@gsantner
Copy link
Owner

On master I noticed that filebrowser dividers are missing in dialogs (i.e. chose Notebook location)

Probably related to your recent question

@harshad1
Copy link
Collaborator Author

Yeah. I just noticed it too. I was just going to revert / fix this.

Although, do we just want to remove the dividers?

Screenshot_20240727-102022

The android files app does not have any dividers and looks pretty good

@gsantner
Copy link
Owner

gsantner commented Jul 27, 2024 via email

elyahw pushed a commit to writing-tools/marelias-notepad that referenced this pull request Sep 26, 2024
…santner#2369, wikitext newfile gsantner#2362, virtual directory browser gsantner#2350) (PR gsantner#2370 by @hardhard1)

* Jump by a line identifier, not by id
* For all nodes, use eval
* Fixed bad key in snippet directory setting
* Fix virtual folders and wikitext underscores

(cherry picked from commit 57aaf0f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment