Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore audio recording #2481

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Conversation

harshad1
Copy link
Collaborator

@harshad1 harshad1 commented Dec 8, 2024

In #2468, audio recording with the stock built in audio recorder was also removed. In this PR I restore recording audio with the built in audio recorder.

@gsantner
Copy link
Owner

gsantner commented Dec 8, 2024

Thanks,

is the audio permission mandatory for it to work - even if a other app actually does the work?

@harshad1
Copy link
Collaborator Author

harshad1 commented Dec 8, 2024

Good catch. Apparently we don't need the permission. Dropped it.

@gsantner gsantner added this to the Markor v2.14 milestone Dec 22, 2024
Copy link
Owner

@gsantner gsantner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gsantner gsantner merged commit 9f4ace5 into gsantner:master Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants