Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Md checkbox action #429

Merged
merged 9 commits into from
Nov 21, 2018
Merged

Md checkbox action #429

merged 9 commits into from
Nov 21, 2018

Conversation

jdckr
Copy link
Contributor

@jdckr jdckr commented Nov 13, 2018

Hi,
I have added a button for checkbox action:

  • if there's no checkbox - [ ] is added
  • if line stats with - [ ] it is replaced with - [x]

Furthermore I adapted MarkDownAutoFormat.java as auto insert of list didn't work for - [ ].

2018-11-13_22-16-03

@gsantner
Copy link
Owner

gsantner commented Nov 21, 2018

@jdckr You recently worked on that area, I think honestly you know better how it works now :=).
I tried it and have not noticed something major. Only found one issue, that is if you have a list, and go nested it always starts with beginning of line (see example below). This can be resolved later too and I'm fine with this happening for now. Merging ;). Thanks for your repeated contribution, always happy about help and hope you continue 👍 .

Example (with underscore being a space):

Currently on git-master:
- text
- more text
  - subitem press enter
  - this is the new item


Now:
- text
- more text
  - subitem press enter
- this is the new item

@gsantner gsantner merged commit dea8ff3 into gsantner:master Nov 21, 2018
@gsantner gsantner added this to the v1.4.1 milestone Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants