Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension trait to add the GGRS plugin more idiomatically #59

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Extension trait to add the GGRS plugin more idiomatically #59

merged 3 commits into from
Jul 6, 2023

Conversation

NiklasEi
Copy link
Contributor

The second commit contains some renaming based on Rust's API guidelines. If you are set on the current naming I can revert it 🙂

johanhelsing
johanhelsing reviewed Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@johanhelsing johanhelsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, both the following naming conventions and the extension method.

Maybe also update the examples to use the extension?

@NiklasEi
Copy link
Contributor Author

Thanks, I had missed the spectator and synctest examples.

@gschup
Copy link
Owner

gschup commented Jun 22, 2023 •
edited
Loading

Thanks for the PR! This seems like a good idea! Sorry for replying so late, but I am terribly busy at the moment.

@gschup gschup merged commit 6a2c590 into gschup:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanhelsing johanhelsing johanhelsing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NiklasEi @gschup @johanhelsing