Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bevy abstractions instead of using instant directly #67

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

johanhelsing
Copy link
Collaborator

This should make writing integration tests easier, since we can then use TimeUpdateStrategy::ManualDuration.

Copy link
Owner

@gschup gschup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes a lot of sense!

@gschup gschup merged commit 88e7bf5 into gschup:main Oct 15, 2023
1 check passed
@gschup
Copy link
Owner

gschup commented Oct 15, 2023

Learning moment for me: are there other bevy utils/abstractions we should use?

@johanhelsing johanhelsing deleted the bevy-time branch October 15, 2023 06:54
@johanhelsing
Copy link
Collaborator Author

Not that I've seen so far. But yeah, I think it makes sense to use the bevy re-exports import paths where possible to make sure we don't use incompatible versions (or cause duplicates in the dependency tree).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants