extra properties in CustomFilter should be objects

gsfk · Feb 3, 2023 · cf21fae · cf21fae
1 parent 381e3ba
commit cf21fae
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/framework/json/requests/filteringTerms.json b/framework/json/requests/filteringTerms.json
@@ -1,8 +1,8 @@
 {
     "$schema": "https://json-schema.org/draft/2020-12/schema",
-    "additionalProperties": true,
     "definitions": {
         "AlphanumericFilter": {
+            "additionalProperties": false,
             "description": "Filter results based on operators and values applied to alphanumeric fields.",
             "properties": {
                 "id": {
@@ -43,6 +43,9 @@
             "type": "object"
         },
         "CustomFilter": {
+            "additionalProperties": {
+                "type": "object"
+            },
             "description": "Filter results to include records that contain a custom term defined by this Beacon.",
             "properties": {
                 "id": {
@@ -75,6 +78,7 @@
             ]
         },
         "OntologyFilter": {
+            "additionalProperties": false,
             "description": "Filter results to include records that contain a specific ontology term.",
             "properties": {
                 "id": {

diff --git a/framework/src/requests/filteringTerms.yaml b/framework/src/requests/filteringTerms.yaml
@@ -47,6 +47,7 @@ definitions:
         type: string
         description: The entry type to which the filter applies
         example: biosamples
+    additionalProperties: false
   AlphanumericFilter:
     description: Filter results based on operators and values applied to alphanumeric
       fields.
@@ -82,6 +83,7 @@ definitions:
         type: string
         description: The entry type to which the filter applies
         example: biosamples
+    additionalProperties: false
   CustomFilter:
     type: object
     description: Filter results to include records that contain a custom term defined
@@ -97,4 +99,5 @@ definitions:
         type: string
         description: The entry type to which the filter applies
         example: biosamples
-additionalProperties: true
+    additionalProperties:
+      type: object