Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some bugs and updated version #31

Merged
merged 5 commits into from
Mar 10, 2013
Merged

Fixed some bugs and updated version #31

merged 5 commits into from
Mar 10, 2013

Conversation

aheusingfeld
Copy link
Collaborator

Fixed broken tests and some other issues.

* added missing reference to PlatformUltraLiteTestFixture
* added missing dependency to idea.jar and trove4j
* upgraded pom.xml to use intellij 12.1.0
* upgraded project.version to 1.0.7
* added changelog link to plugin.xml

Issues: #27
@gshakhn
Copy link
Owner

gshakhn commented Mar 8, 2013

Thanks for the pull request! I have a few minor concerns on the #27 commit that I commented on.

- updated install-intellij-libs.sh to easily install all JARs in IntelliJ's lib folder
- referenced jars from the lib folder in our pom.xml
- updated README.md

Issues: #31
@aheusingfeld
Copy link
Collaborator Author

Hi George,

on your questions:

  1. the plugin now builds and runs with 12.0.4 but is not usable with versions older than 123.168 (as you specified in pom.xml)
  2. I stumbled over SpringSource EBR when I was searching for the version of trove4j used in IntelliJ. I used EBR for an OSGi project some time ago, so I took a peek at it. Seems the jetbrains guys patched a rather old version of trove4j but the patches somehow weren't merged back into the origin.

But that doesn't matter now as I modified the shell script to install all jars from IntelliJ's lib folder into the local maven repo and adjusted pom.xml accordingly.

- resized sonar.png to 13x13 pixel

Issues: #29
gshakhn added a commit that referenced this pull request Mar 10, 2013
Fixed some bugs and updated version
@gshakhn gshakhn merged commit f373aa0 into gshakhn:master Mar 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants