Adding Configurable Exponential Backoff in Pull Delivery #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gcaya
reviewed
Jul 18, 2024
...leap.DomainEventPropagation.Subscription.PullDelivery/EventPropagationSubscriptionOptions.cs
Outdated
Show resolved
Hide resolved
Gcaya
reviewed
Jul 18, 2024
src/Workleap.DomainEventPropagation.Subscription.PullDelivery/EventPullerService.cs
Outdated
Show resolved
Hide resolved
meziantou
reviewed
Jul 18, 2024
src/Workleap.DomainEventPropagation.Subscription.PullDelivery/EventPullerService.cs
Show resolved
Hide resolved
meziantou
reviewed
Jul 18, 2024
src/Workleap.DomainEventPropagation.Subscription.PullDelivery/EventPullerService.cs
Show resolved
Hide resolved
meziantou
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A new RetryDelays configuration parameter was added, which gives control over the delays before releasing the lock on failed domain events in Pull Delivery mode.
The tests were also completely rewritten, as dealing with the previous implementation with AutoBogus led to more issues than benefits.
Breaking changes
If the new parameter is not set, a default implementation of an exponential backoff is provided. This means that after updating, failed domain events will be released over a progressively longer period time versus before, where they were immediately released.
Additional checks