Map the intended delays to the nearest supported delay #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gcaya
reviewed
Aug 14, 2024
src/Workleap.DomainEventPropagation.Subscription.PullDelivery/EventPullerService.cs
Outdated
Show resolved
Hide resolved
meziantou
reviewed
Aug 14, 2024
src/Workleap.DomainEventPropagation.Subscription.PullDelivery.Tests/EventPullerServiceTests.cs
Outdated
Show resolved
Hide resolved
meziantou
reviewed
Aug 14, 2024
src/Workleap.DomainEventPropagation.Subscription.PullDelivery/EventPullerService.cs
Outdated
Show resolved
Hide resolved
Gcaya
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When releasing an event lock in the Pull Delivery mode, it is possible to specify a release delay.
It turns out that the API allows an int, but will only support specific values for that parameter. This PR maps the intended delays to the nearest supported delay by the API, in order to prevent errors.
Breaking changes
None
Additional checks