[IDP-2334] Add client side max retries count for pull delivery #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meziantou
approved these changes
Oct 9, 2024
meziantou
changed the title
Co-authored-by: Gérald Barré <meziantou@users.noreply.github.com>
meziantou
approved these changes
Oct 9, 2024
…ivery_count' into feature/idp-2334_respect_max_delivery_count # Conflicts: # README.md
meziantou
approved these changes
Oct 9, 2024
PrincessMadMath
deleted the
feature/idp-2334_respect_max_delivery_count
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a client side max retries count for the delivery model.
When the delivery attend exceed the max retry configuration it get rejected to be send to the Dead Letter Queues instead of being released.
Breaking changes
Not breaking but the behavior has changed: message will be put in DLG instead of being drop.
Additional checks