Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a reusable workflow for terraform #26

Merged
merged 31 commits into from
Sep 26, 2024
Merged

Add a reusable workflow for terraform #26

merged 31 commits into from
Sep 26, 2024

Conversation

guillaume-pb-workleap
Copy link
Contributor

@guillaume-pb-workleap guillaume-pb-workleap commented Sep 25, 2024 •
edited
Loading

This PR is about:

  • Create a reusable workflow for terraform repos.
  • Add a rule file to reuse by tflint
  • This is meant to be use on any branch pushes unless it is the main branch

@guillaume-pb-workleap guillaume-pb-workleap requested a review from a team as a code owner September 25, 2024 20:25
@asimmon asimmon marked this pull request as draft September 25, 2024 20:34
@asimmon asimmon marked this pull request as ready for review September 25, 2024 20:34
@asimmon asimmon requested a review from a team as a code owner September 25, 2024 20:34
asimmon
asimmon previously approved these changes Sep 25, 2024
View reviewed changes
@asimmon asimmon dismissed their stale review September 25, 2024 20:35

Just testing

starcraft66
starcraft66 requested changes Sep 25, 2024
View reviewed changes
.github/workflows/terraform-on-branch-push.yml Outdated Show resolved Hide resolved
.github/workflows/terraform-on-branch-push.yml Outdated Show resolved Hide resolved
.github/workflows/terraform-on-branch-push.yml Outdated Show resolved Hide resolved
.github/workflows/terraform-on-branch-push.yml Outdated Show resolved Hide resolved
.github/workflows/terraform-on-branch-push.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
starcraft66
starcraft66 requested changes Sep 26, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
Guillaume P.B added 2 commits September 26, 2024 09:39
@guillaume-pb-workleap guillaume-pb-workleap marked this pull request as draft September 26, 2024 13:59
@guillaume-pb-workleap
Copy link
Contributor Author

Converted back to draft as I will try to package the linter rule file to be a reusable template.

@guillaume-pb-workleap guillaume-pb-workleap marked this pull request as ready for review September 26, 2024 14:25
Guillaume P.B added 2 commits September 26, 2024 10:30
@guillaume-pb-workleap guillaume-pb-workleap force-pushed the feature/idp-2291-create-reusable-tf-workflow branch from 8e34d1b to db5a140 Compare September 26, 2024 14:44
starcraft66
starcraft66 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@starcraft66 starcraft66 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to figure out an ergonomic way of re-running checks (probably with a dreaded PAT) to re-run checks once the formatting bot has committed.

LGTM for now

@guillaume-pb-workleap guillaume-pb-workleap merged commit 87028cc into main Sep 26, 2024
2 checks passed
@guillaume-pb-workleap guillaume-pb-workleap deleted the feature/idp-2291-create-reusable-tf-workflow branch September 26, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starcraft66 starcraft66 starcraft66 approved these changes

@asimmon asimmon asimmon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaume-pb-workleap @starcraft66 @asimmon