Fix various issues detected by static analysis and invalid file mode in systemd service file #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrisc
changed the title
simo5
requested changes
Aug 7, 2024
There was a problem hiding this comment.
One broken change, and one question.
Changing the tests is a bit pedantic given all file descriptors get closed when the test completes anyway, but I am not against keeping static analysis tools quiet.
I would suggest though that you simply change your configuration of your static analysis tools to ignore the tests directory, for tests this is just churn and we should avoid it.
jrisc
force-pushed
the
various_fixes
branch
2 times, most recently
from
8ae192a to
fbbb6a4
Compare
Signed-off-by: Julien Rische <jrische@redhat.com>
The provided gssproxy.service unit configures /var/lib/gssproxy/clients and /var/lib/gssproxy/rcache as "StateDirectory". However, systemd applies mode 0755 by default on such folders. "StateDirectoryMode" has to be set too to restrict access to root only. Signed-off-by: Julien Rische <jrische@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some fixes based on reports from static analysis tools (mainly related to unreleased resources and uninitialized variables), and a fix for the provided systemd service file, which causes invalid file mode to be set on cache folders.