Fix issues with socket activation. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust systemd's service file for usermode. Socket activation requires that we used the interactive mode (-i) so that gssproxy does not fork on startup. Forking causes sd_listen_fds() to fail as that function checks that the pid of the process calling it is the same process systemd forked via the internal envvar LISTEN_PID. Additionally make sure to set the socket name for the artificial config service in usermode as well as the socket set up during socket activation to all use the same string (the usermode socket) so that the checks in gp_creds_match_conn() work properly in the socket activation case too. Signed-off-by: Simo Sorce <simo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #46