Refactor initialization and self termination code #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event loop cycles too often to use verto_run_once() as a way to deal with marking activity. So revert to using verto_run() and set the termination handler once for now. Signed-off-by: Simo Sorce <simo@redhat.com>
Refactor init functions and move them in the appropriate file. Signed-off-by: Simo Sorce <simo@redhat.com>
These are functions that are used to manage the proxy own main process after initialization. Store in their own file so the scope is clear. Signed-off-by: Simo Sorce <simo@redhat.com>
Self termination need to happen only when gssproxy is idle for a certina amount of time. However due to non material activity the gssproxy performs through the verto event handler we need to actively measure ideling rather than depend on things like verto_idle. Ad an accounting function to our socket handler. This now allows us to collect some interesting statistics as well as reset the idle handler when there is actual activity ongoing. We reset the handler only upon receiving data from a client, as that indicates a requested activity. Writes happen only as reposnses and are considered part of a single activity event together with the read that caused the idel handler reset. Signed-off-by: Simo Sorce <simo@redhat.com>
Currently just checks that initialization and self termination actually happened. Signed-off-by: Simo Sorce <simo@redhat.com>
|
Manual testing works + added basic testing for self termination in userproxytest.c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self termination was not happening if the timeout was larger than about 1 minute, due to the event loop self management which makes it return to the calling function regularly.
In order to ignore unimportnat events that wake up the event loop it means we cannot measure idleness from the event loop general activity but we need to do so via measuring actual significant events.
Actual activity happens when clients make requests, so use the socket reader events as signal to reset the idler event.
While there also gather some statistics that can be printed ad debug level 1 (INFO).