Restore full support for krb5 traces in debugging #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simo Sorce <simo@redhat.com>
The proccess stderr may be redirected to a socket or a pipe by the parent process (which is what systemd does for example). When that happen we can't simply pass a valid path to stderr so that libkrb5 can send the tracing via the KRB5_TRACE environment variable to a our stderr, passing /dev/stderr in this case will just result in an open error and tracing output going nowhere. To handle this we create our own fifo to pass to libkrb5 and then we create a thread that reads the incoming data and pipes it back to the stderr we've been given by our parent. Signed-off-by: Simo Sorce <simo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some case /dev/stderr does not point to a path that can be opened with open()
This is the case for example where stderr is redirect to a pipe/socket/fifo.
Systemd init does this in order to capture the standard error in the logs for example.
To deal with this case we crate our own redirecting fifo.
Fixes #44