Move some configure checks out of a condition #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was too aggressive in moving all systemd checks, some of them need to be performed at all times because there are conditionals ependent on the detection. The actual build for gss-only module is controlled by the BUILD_PROXY guard anyway, so the checking unconditionally should not cause any change for that configuration even when unused. Signed-off-by: Simo Sorce <simo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was too aggressive in moving all systemd checks, some of them need to
be performed at all times because there are conditionals ependent on the
detection.
The actual build for gss-only module is controlled by the BUILD_PROXY
guard anyway, so the checking unconditionally should not cause any
change for that configuration even when unused.
Fixes #54