Add warnings if s4u2proxy options are inconsistent #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/mod_auth_gssapi.c
Outdated
| /* we check only once */ | ||
| if (cfg->verified) return; | ||
|
|
||
| /* Check if cred store donfig is consistent with use_s4u2proxy. |
In most cases, people configuring GssapiUseS4U2Proxy should really set all three cred store options for keytab, client_keytab, and ccache to isolate httpd from default system ccaches and keytabs. Not doing so unintentionally easily leads to very hard to debug issues when trying to use the proxying feature. Not enforcing as a hard misconfiguration both for compatibility reasons and also because there are corner cases where the configuration is intentional. Signed-off-by: Simo Sorce <simo@redhat.com> [rharwood@redhat.com: typo fix and commit message cleanup] Reviewed-by: Robbie Harwood <rharwood@redhat.com>
frozencemetery
force-pushed
the
more_proxy_checks
branch
from
38ef05b to
b4b43c2
Compare
|
Seems like this is broken, causing a crash in httpd during FreeIPA server deployment. https://bugzilla.redhat.com/show_bug.cgi?id=2121952 . I'm guessing it's not safe to assume |
|
One thing I notice, shouldn't this whole thing be inside a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases people configuring GssapiUseS4U2Proxy should really
set all three cred store options for keytab, client_keytab and ccache,
to isolate httpd from default system ccaches and keytabs.
Not doing so unintentionally, easily lead to very hard to debug issues
when trying to use the proxying feature.
NOt enforcing as a hard misconfiguration both for compatibility reasons
and also because there are corner cases where the configuration is
intentional.
Fixes #230