New effect: Cocktail shaker #3569
Conversation
There was a problem hiding this comment.
Ensure that you are using clang formatting on MiscCocktail.cpp. The easiest way to achieve this in Visual Studio is by pressing CTRL+K followed by CTRL+D. This will format the current file. Otherwise, everything looks fine. I'll let Pongo do the final review.
| x = sin((360 - rot) * PI / 180) * 1.33; | ||
| y = -cos((360 - rot) * PI / 180) * 1.33; |
There was a problem hiding this comment.
| x = sin((360 - rot) * PI / 180) * 1.33; | |
| y = -cos((360 - rot) * PI / 180) * 1.33; | |
| x = sin((360 - rot) * PI / 180) * 1.33f; | |
| y = -cos((360 - rot) * PI / 180) * 1.33f; |
Don't think we need doubles here
There was a problem hiding this comment.
precomputing pi/180 would save some CPU cycles.
There was a problem hiding this comment.
PI is defined in multiple other effects, could it be worth adding it to a common header file? Of course PI won't change, though it would still feel ""cleaner"" to have it defined in one place.
There was a problem hiding this comment.
I believe there is a DirectX header that includes all the common pi values such as pi/180, 180/pi, 2*pi, ect...
There was a problem hiding this comment.
Having a header file would be better than including the DirectX headers just when we need PI.
There was a problem hiding this comment.
I believe it's better to use SYSTEM::SIN and SYSTEM::COS natives: they work with angles in degrees, so you won't have to use the value of pi.
There was a problem hiding this comment.
Wouldn’t it bet better to use the math functions from math.h, instead of calling it through game natives. Would definitely be faster.
There was a problem hiding this comment.
cmath has all of that. But I don't see one for PI/180
#define _USE_MATH_DEFINES // for C++
#include <cmath>
#define _USE_MATH_DEFINES // for C
#include <math.h>
Value definitions: https://learn.microsoft.com/en-us/cpp/c-runtime-library/math-constants?view=msvc-170#remarks
There was a problem hiding this comment.
we could (and probably should) just create our own header file that has definitions for all the possible numbers we could need and just include that file in stdafx.h.
There was a problem hiding this comment.
so what am i supposed to do now
Co-authored-by: pongo1231 <pongo1999712@gmail.com>
|
Looks good to me 👍 |
Shakes all vehicles and props (not peds) back and forth, perpendicular to the direction the player is facing when the effect is triggered.