Disentangle docsrs and features #1154
Conversation
|
Now that the gir changes have landed, it would be great to also update & regenerate the sys crate. |
|
Are you asking me to do it and add it to the PR? I see that you approved it already, so I am not sure |
Yes, please Just make sure the update submodule commit is separate from the regeneration, as that would simplify backporting |
|
Actually, I will do that along with more changes |
bilelmoussaoui
added
the
needs-backport
| @@ -84,19 +84,19 @@ pub use socket_msg_flags::SocketMsgFlags; | |||
| mod subprocess; | |||
| mod subprocess_launcher; | |||
| mod threaded_socket_service; | |||
| #[cfg(any(unix, docsrs))] | |||
| #[cfg(unix)] | |||
There was a problem hiding this comment.
Is this actually correct? This way we won't get docs for this unless building on a unix-y system?
There was a problem hiding this comment.
I think that is correct yes, but i would refer to @GuillaumeGomez here
There was a problem hiding this comment.
That seems like a problem then. Previously we got platform-specific docs when building docs on any platform. There's quite a bit of compat hackery for that :)
bilelmoussaoui
added
backported
Remaining cleanup from #1078