gio: fix UnixSocketAddress constructor with a path #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as draft because even with the length fixed by passing -1 to glib, the unit test still fails. |
|
(Also I need to drop the gir and gir-files changes, but that is secondary) |
pbor
force-pushed
the
unix-socket-addr
branch
from
beda594
to
3a6ace4
Compare
as_os_str().len() does not return the number of bytes in the string, but the full allocation size. Just pass -1 and let glib calculate the len.
pbor
force-pushed
the
unix-socket-addr
branch
from
3a6ace4
to
f0eff3f
Compare
|
The problem was that the stash did not live long enough |
bilelmoussaoui
added
the
needs-backport
sdroege
approved these changes
Nov 2, 2023
sdroege
removed
the
needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as_os_str().len() does not return the number of bytes in the string, but the full allocation size. Just pass -1 and let glib calculate the len.