glib: Implement Regex #947

davidmhewitt · 2023-02-03T11:28:33Z

I'm interested in generating bindings for https://github.com/elementary/granite which exposes GLib.Regex as part of its public API, so it would be good to have these in the glib crate to depend on.

glib/src/regex.rs

glib/src/auto/regex.rs

glib/src/auto/match_info.rs

sdroege

Looks good to me otherwise, thanks!

jf2048 · 2023-02-04T14:52:23Z

Not a blocker, but it would be good if eventually we could have a documentation note here saying this should not really be used by Rust programs except for compatibility reasons. No one should ever be writing new code with this unless necessary, e.g. calling those libgranite APIs that need it. There are much better native Rust implementations, even the pcre2 crate is better than using this.

Edit: some more background here https://gitlab.gnome.org/GNOME/glib/-/issues/1085#note_1270415

bilelmoussaoui · 2023-10-26T18:57:09Z

Would you mind rebasing this one?

bilelmoussaoui

otherwise lgtm

glib/Gir.toml

glib/src/auto/regex.rs

glib/src/auto/match_info.rs

glib/src/regex.rs

sdroege · 2023-10-27T06:50:09Z

Looks good to me apart from those trivial things. Once that's all covered, can you squash the commits together?

glib/src/lib.rs

davidmhewitt · 2023-10-27T10:19:41Z

Thank you both for the feedback, I'll work on addressing the last few comments over the next few hours.

But first, a question:

It looks like I initially manually implemented a lot of these methods so we could use impl IntoGStr in the arguments instead of &str. The methods generated by gir are otherwise identical.

Is it still the case that it would be preferred to have manually written bindings just to get impl IntoGStr here, or should I revert most of these methods back to the automatically generated versions that use &str?

sdroege · 2023-10-27T10:29:37Z

Keep them like this until gir supports generating them like this. That's what the comment in Gir.toml should say why they're not autogenerated.

These modules are inefficient and should not be used by Rust programs except for compatibility with GLib.Regex based APIs. All methods are implemented except for g_regex_replace_eval

davidmhewitt · 2023-10-27T12:27:24Z

I have resolved all feedback apart from the non-blocking comment about the missing implementation of g_regex_replace_eval and squashed my commits.

Thanks again for your reviews, let me know if there's anything else I can do here.

bilelmoussaoui · 2023-10-27T12:43:47Z

Looks good enough, we can always iterate later if needed. Thank you for your contribution

sdroege · 2023-11-12T07:58:28Z

This has some soundness issues, see #1223

sdroege self-requested a review February 3, 2023 12:14

sdroege added this to the 0.17.0 milestone Feb 3, 2023