This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Switch to version features instead of autodetection #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Installed library version detection no longer impacts conditional compilation. - Each crate defaults to supporting a particular minimal upstream version. - Higher (newer) versions need to be enabled via cargo features e.g. `--features 3.16`, `features = ["3.16"]`. - The selected version is checked against `pkg-config` aborting the build if it's too high. - The use of `pkg-config` can be overridden by setting `GTK_LIB_DIR` env variable, which translates into `-L $GTK_LIB_DIR` linker argument. No version checks are done in this case. [breaking change]
|
Naturally this can't be tested by our CI tools. It's been preliminary tested locally but we'll only know after merging everything. |
GuillaumeGomez
added a commit
that referenced
this pull request
Feb 13, 2016
Switch to version features instead of autodetection
EPashkin
pushed a commit
to EPashkin/gtk
that referenced
this pull request
Apr 18, 2016
Add myself to the authors and put license headers where they're missing
alex179ohm
pushed a commit
to alex179ohm/gtk
that referenced
this pull request
Oct 21, 2019
Add collecting statistics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the reinstatement of version features outlined in #243.
--features 3.16,features = ["3.16"].pkg-configaborting the build if it's too high.pkg-configcan be overridden by settingGTK_LIB_DIRenv variable, which translates into-L $GTK_LIB_DIRlinker argument. No version checks are done in this case.[breaking change]