Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

gio: use default methods when possible for ActionGroup #263

Merged
merged 1 commit into from
Jan 16, 2021
Merged

gio: use default methods when possible for ActionGroup #263

merged 1 commit into from
Jan 16, 2021

Conversation

bilelmoussaoui
Copy link
Member

@ids1024
Copy link
Contributor

ids1024 commented Jan 15, 2021

Now this only requires implementing two methods, as expected. Though it would be good to have an example and perhaps a unit test (or more).

sdroege
sdroege approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in and add a test/example later? Or do you want to prepare one now?

@bilelmoussaoui
Copy link
Member Author

Let's get this in and add a test/example later? Or do you want to prepare one now?

I do want to add one, but not today :) I would prefer to have this merged as it's right now

@sdroege sdroege merged commit 673f754 into master Jan 16, 2021
@sdroege sdroege deleted the bilelmoussaoui/gio/actions-fixes branch January 16, 2021 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bilelmoussaoui @ids1024 @sdroege