This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Subclassing refactoring #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also move property installation from a manual function call to a trait function with default implementation. This simplifies handling of properties in subclasses.
Remove meaningless flags and add user-defined flags.
This is redundant with the GBoxed derive macro.
sdroege
force-pushed
the
class-refactoring
branch
from
8232aba to
2eda9ed
Compare
GuillaumeGomez
approved these changes
Jan 21, 2021
bilelmoussaoui
approved these changes
Jan 21, 2021
…aces the subclass should implement The macro magic is adapted from nom.
This way we can ensure they're equivalent even if the function is called multiple times.
sdroege
force-pushed
the
class-refactoring
branch
from
2eda9ed to
df52c8f
Compare
|
@bilelmoussaoui @GuillaumeGomez Can you review the newest commit too? That's doing the whole thing for signals now. I think that's a much nicer API, and it also gives a way for calling signals from subclasses more nicely. |
|
From my side this PR is ready, but before merging this I'd like to update all of GStreamer to not have it fail to build for too long. I'll probably spend Saturday or Sunday with that, it will take some time. |
sdroege
force-pushed
the
class-refactoring
branch
from
df52c8f to
8b74a4c
Compare
|
https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/613 for the GStreamer side of things. Nice cleanup. Now I just need to port over all the 50 or so subclasses in gst-plugins-rs 😭 |
GuillaumeGomez
approved these changes
Jan 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #31 for now, I'll update that one to only include the
Valuechanges once this one is merged.TODO
fn signals() -> &'static [Signal]method toObjectSubclass